-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relgen: Second gen relnotes generator first commit. #6184
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpe442
added
the
deploy
Add this label to a PR and it will automatically be deployed to netlify
label
Oct 25, 2024
github-actions
bot
temporarily deployed
to
pr-6184-docs-tools-relnote-generator-two
October 25, 2024 15:03
Inactive
github-actions
bot
temporarily deployed
to
pr-6184-docs-tools-relnote-generator-two
October 28, 2024 11:05
Inactive
github-actions
bot
temporarily deployed
to
pr-6184-docs-tools-relnote-generator-two
October 28, 2024 12:41
Inactive
github-actions
bot
temporarily deployed
to
pr-6184-docs-tools-relnote-generator-two
October 28, 2024 14:07
Inactive
github-actions
bot
temporarily deployed
to
pr-6184-docs-tools-relnote-generator-two
October 28, 2024 15:37
Inactive
github-actions
bot
temporarily deployed
to
pr-6184-docs-tools-relnote-generator-two
October 29, 2024 10:09
Inactive
github-actions
bot
temporarily deployed
to
pr-6184-docs-tools-relnote-generator-two
October 29, 2024 14:23
Inactive
github-actions
bot
temporarily deployed
to
pr-6184-docs-tools-relnote-generator-two
October 30, 2024 05:50
Inactive
josh-heyer
force-pushed
the
docs/tools/relnote-generator-two
branch
from
October 30, 2024 18:16
091781f
to
66eaff6
Compare
⚠Rebased to fix link errors |
github-actions
bot
temporarily deployed
to
pr-6184-docs-tools-relnote-generator-two
October 30, 2024 18:21
Inactive
github-actions
bot
temporarily deployed
to
pr-6184-docs-tools-relnote-generator-two
October 30, 2024 18:37
Inactive
Signed-off-by: Dj Walker-Morgan <[email protected]>
Signed-off-by: Dj Walker-Morgan <[email protected]>
Signed-off-by: Dj Walker-Morgan <[email protected]>
Signed-off-by: Dj Walker-Morgan <[email protected]>
Signed-off-by: Dj Walker-Morgan <[email protected]>
Signed-off-by: Dj Walker-Morgan <[email protected]>
Also clean up display of code blocks a bit, and implement some sensible page breaks
Also some sensible layout and page break controls for printing
Also fix omitted import in relgen.js
djw-m
force-pushed
the
docs/tools/relnote-generator-two
branch
from
November 14, 2024 17:02
6ae9a93
to
f9224ca
Compare
github-actions
bot
temporarily deployed
to
pr-6184-docs-tools-relnote-generator-two
November 14, 2024 17:14
Inactive
josh-heyer
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems pretty solid; it's a clear improvement over what we have now, and it would be good to put this to use during releases as soon as possible.
Todo in the future:
- more robust handling of input strings (currently possible to break table rendering with poor choice of date or version names)
- Pretty-printing for both Markdown and HTML tables
Signed-off-by: Dj Walker-Morgan <[email protected]>
Noted on the changes. Feeling pretty, might make tickets later. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
Builds on relnoted but is independent of it.
relgen.js -p relnotedir
Reads config from src/meta.yml
Then processes all the release notes files in the directory
Creates index.mdx and releasenote files.